Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add beta-4-rc-2 dist channel support #467

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Aug 15, 2023

Adds beta-4-rc2 support to fuelup so that people can install it via:

fuelup toolchain install beta-4-rc.2

Unfortunately due to how fuelup parses toolchain metadata it is not straightforward to make it possible to use:

fuelup toolchain install beta-4-rc-2

We can support it later on and change the name if necessary as this is more towards to our internal testing, I feel like timing is has a little priority rn, but happy to mark this as draft and handle that if it seems like blocker.

@kayagokalp kayagokalp added the enhancement enhancement to a current feature label Aug 15, 2023
@kayagokalp kayagokalp self-assigned this Aug 15, 2023
@kayagokalp
Copy link
Member Author

kayagokalp commented Aug 15, 2023

blocked by #469

@kayagokalp kayagokalp requested a review from a team August 15, 2023 17:32
@kayagokalp kayagokalp enabled auto-merge (squash) August 15, 2023 17:32
@JoshuaBatty
Copy link
Member

I think the correct way would be beta-4-rc.2 . This is the convention rust crates use. Would this be hard to implement in this PR?

@kayagokalp
Copy link
Member Author

I think the correct way would be beta-4-rc.2 . This is the convention rust crates use. Would this be hard to implement in this PR?

Sounds good! pushed efbcee2, now it should be installing beta-4-rc-2 with fuelup toolchain install beta-4-rc.2.

@kayagokalp kayagokalp merged commit 4d4f425 into master Aug 16, 2023
15 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/add-fuel-beta-4-rc2 branch August 16, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants