Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a monomorphization cache #2636

Closed
Tracked by #1819
emilyaherbert opened this issue Aug 26, 2022 · 2 comments
Closed
Tracked by #1819

Introduce a monomorphization cache #2636

emilyaherbert opened this issue Aug 26, 2022 · 2 comments
Assignees
@emilyaherbert
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen

Comments

@emilyaherbert
Copy link
Contributor

Instead of creating one monomorphized copy per expression, we should create a monomorphization cache to keep track of monomorphized copies that we have created in the past, so that we can eliminate duplicate computation
@emilyaherbert emilyaherbert added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Aug 26, 2022
@emilyaherbert emilyaherbert mentioned this issue Aug 26, 2022
Closed
@emilyaherbert emilyaherbert mentioned this issue Aug 26, 2022
Closed
13 tasks
tritao added a commit to tritao/sway that referenced this issue Aug 29, 2022
@tritao
Add a monomorphization cache to the declaration engine.
9725feb 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
@tritao tritao mentioned this issue Aug 29, 2022
Closed
tritao added a commit to tritao/sway that referenced this issue Aug 29, 2022
@tritao
Add a monomorphization cache to the declaration engine.
7209d08 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
tritao added a commit to tritao/sway that referenced this issue Aug 31, 2022
@tritao
Add a monomorphization cache to the declaration engine.
b24c10d 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
tritao added a commit to tritao/sway that referenced this issue Sep 1, 2022
@tritao
Add a monomorphization cache to the declaration engine.
248ab50 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
tritao added a commit to tritao/sway that referenced this issue Sep 1, 2022
@tritao
Add a monomorphization cache to the declaration engine.
8dde354 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
tritao added a commit to tritao/sway that referenced this issue Sep 5, 2022
@tritao
Add a monomorphization cache to the declaration engine.
2a59131 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
tritao added a commit to tritao/sway that referenced this issue Sep 5, 2022
@tritao
Add a monomorphization cache to the declaration engine.
e8b9e2a 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
tritao added a commit to tritao/sway that referenced this issue Sep 5, 2022
@tritao
Add a monomorphization cache to the declaration engine.
44bd2c5 
This introduces a cache to the declaration engine that keeps track of
functions/structs that have been instantiated from a specific set
of type parameters.

This was originally prototyped in
tritao/declaration-engine-and-collection-context-demo@c3aa5e7,
where these APIs where wired
to the function application and struct expressions instantiation code.

However given the declaration engine is not hooked up yet here, this
PR is just adding the APIs, and more proper testing will be added as we
wire things up.

Closes FuelLabs#2636.
This was referenced Sep 12, 2022
Closed
Closed
@emilyaherbert
Copy link
Contributor Author

See this closed PR description for additional context and insight into a possible design: #2723 (comment)

@tritao tritao mentioned this issue Sep 23, 2022
Open
@emilyaherbert emilyaherbert mentioned this issue Oct 26, 2022
Merged
@emilyaherbert emilyaherbert mentioned this issue Jan 31, 2023
Closed
@tritao tritao assigned emilyaherbert and unassigned tritao Mar 6, 2023
@emilyaherbert
Copy link
Contributor Author

Closing this issue based on chatting with @IGI-111 as it will be included in the implementation for #1267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilyaherbert emilyaherbert

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Milestone
No milestone
2 participants
@tritao @emilyaherbert