Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle where clause for traits #4560

Closed
Tracked by #970
IGI-111 opened this issue May 12, 2023 · 0 comments · Fixed by #4584
Closed
Tracked by #970

Handle where clause for traits #4560

IGI-111 opened this issue May 12, 2023 · 0 comments · Fixed by #4584
Assignees
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen enhancement New feature or request language feature Core language features visible to end users P: critical Should be looked at before anything else

Comments

@IGI-111
Copy link
Contributor

IGI-111 commented May 12, 2023

The where clause for traits is currently parsed but not actually handled in later stages.

@IGI-111 IGI-111 added enhancement New feature or request language feature Core language features visible to end users P: critical Should be looked at before anything else compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels May 12, 2023
esdrubal added a commit that referenced this issue May 24, 2023
With these changes where clauses are enabled for traits.
This commit also adds error handling when an `impl` is created for a generic
trait with where clause.

Generic traits are not supported yet on super traits or where clauses,
when the support is added we should also perform the bounds check there.

Fixes #4560
Fixes #970
esdrubal added a commit that referenced this issue May 24, 2023
With these changes where clauses are enabled for traits.
This commit also adds error handling when an `impl` is created for a generic
trait with where clause.

Generic traits are not supported yet on super traits or where clauses,
when the support is added we should also perform the bounds check there.

Fixes #4560
Fixes #970
esdrubal added a commit that referenced this issue May 25, 2023
## Description

With these changes where clauses are enabled for traits. This commit
also adds error handling when an `impl` is created for a generic trait
with where clause.

Generic traits are not supported yet on super traits or where clauses,
when the support is added we should also perform the bounds check there.

Fixes #4560
Fixes #970

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen enhancement New feature or request language feature Core language features visible to end users P: critical Should be looked at before anything else
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants