Pushing a StorageString to StorageVec overwrites all values with the latest
#6036
Comments
8 tasks
ironcev
added a commit
that referenced
this issue
May 22, 2024
## Description This PR fixes #6036 by using `field_id()` in the `StorageString` instead of `slot()`. Additionally, the PR: - fixes documentation glitches in the `StorageVec`. - optimizes `StorageMap::get` by removing double calculation of the `key`. - cleans up most of the Sway and all Rust warnings in the SDK harness tests. The PR is not solving all the issues related to composing dynamic storage types. E.g, #6040 is (very likely just one) of them. Closes #6036. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the minimal repro and issue description see: https://github.com/MoMannn/sway-vec/tree/master
Hint:
StorageStringshould usefield_id()instead of theslot().The text was updated successfully, but these errors were encountered: