Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch incorrect number of function arguments in type checking instead of code generation. #250

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Catch incorrect number of function arguments in type checking instead of code generation. #250

merged 1 commit into from
Sep 21, 2021

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Sep 20, 2021 •
edited
Loading

image

Closes #243

Adds:

  1. Tests for both too many and too few arguments
  2. Fix where a missing argument would get caught by an ugly internal error in code generation instead of type checking.

See #243 for more details.

@sezna sezna self-assigned this Sep 20, 2021
@sezna sezna added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Sep 20, 2021
@sezna sezna merged commit 350a253 into master Sep 21, 2021
@sezna sezna deleted the sezna/243 branch September 21, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho otrho approved these changes

@emilyaherbert emilyaherbert Awaiting requested review from emilyaherbert

Assignees

@sezna sezna

Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem type checking functions called with missing arguments.
2 participants
@sezna @otrho