Short circuit bool ops. #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyaherbert
previously approved these changes
Sep 23, 2021
sezna
previously approved these changes
Sep 23, 2021
| @@ -964,8 +987,8 @@ impl OpVariant { | |||
| Divide => "divide", | |||
| Multiply => "multiply", | |||
| Modulo => "modulo", | |||
| Or => "or", | |||
| And => "and", | |||
| Or => "$or$", | |||
There was a problem hiding this comment.
this just prevents it from calling the stdlib version?
A new LazyOperator expression variant is introduced, type-checked and and converted to fairly simple ASM. These operators are no longer allowed to be overridden because they must be evaluated lazily and this can't be enforced with a trait. Instead, they're now compiler intrinsics.
`&&` and `||` are no longer overidable method invocations in std::ops, but rather intrinsic compiler operations.
otrho
force-pushed
the
otrho/226_short_circuit_bool_ops
branch
from
8e7106a
to
6a2d592
Compare
sezna
approved these changes
Sep 24, 2021
adlerjohn
added
the
compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226.
I've special cased
&&and||to no longer be overriddenstd::ops::...method invocations and have instead created a newExpression::LazyOperatorvariant. It is type checked into aTypedExpression::LazyOperatorwhich translates to custom ASM gen for the lazy evaluation.Initially I was thinking it could be a special
FunctionApplicationwhich we detected and special-cased in the ASM gen, but I think this approach is nicer.