Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: workspace level patch table added #4086

Merged
merged 12 commits into from
Apr 19, 2023
Merged

feat: workspace level patch table added #4086

merged 12 commits into from
Apr 19, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Feb 15, 2023 •
edited

Description

closes #3958.

This is a handy feature for tests with workspaces. We were already supporting a patch table feature for packages. This PR adds the same feature for workspaces. Basically we can patch every instance of a package with a different version. One main motivation behind this can be patching the standard library while working with an unreleased version of forc. With this feature we can pin the std version for the whole workspace so that all members in the workspace depending on std would depend on master version of the std.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added enhancement New feature or request forc-pkg Everything related to the `forc-pkg` crate. labels Feb 15, 2023
@kayagokalp kayagokalp self-assigned this Feb 15, 2023
@kayagokalp kayagokalp marked this pull request as ready for review February 16, 2023 11:24
@kayagokalp kayagokalp requested a review from a team February 16, 2023 11:24
eightfilms
eightfilms suggested changes Feb 16, 2023
View reviewed changes
forc-pkg/src/manifest.rs Outdated Show resolved Hide resolved
forc-pkg/src/manifest.rs Outdated Show resolved Hide resolved
docs/book/src/forc/workspaces.md Show resolved Hide resolved
@eightfilms eightfilms requested a review from a team February 16, 2023 12:53
eightfilms
eightfilms previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@eightfilms eightfilms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eightfilms eightfilms requested a review from a team February 16, 2023 13:47
mitchmindtree
mitchmindtree suggested changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this Kaya!

docs/book/src/forc/workspaces.md Outdated Show resolved Hide resolved
docs/book/src/forc/workspaces.md Outdated Show resolved Hide resolved
@kayagokalp kayagokalp marked this pull request as draft February 20, 2023 00:32
@kayagokalp kayagokalp marked this pull request as ready for review April 10, 2023 02:27
@kayagokalp kayagokalp enabled auto-merge (squash) April 10, 2023 02:28
@kayagokalp @eightfilms
remove unnecessary Oks
f0bcfde 
Co-authored-by: bing <bingcicle@proton.me>
mitchmindtree
mitchmindtree reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a couple small final suggestions!

docs/book/src/forc/workspaces.md Show resolved Hide resolved
forc-pkg/src/manifest.rs Show resolved Hide resolved
@kayagokalp kayagokalp marked this pull request as draft April 13, 2023 22:02
auto-merge was automatically disabled April 13, 2023 22:02

Pull request was converted to draft

@kayagokalp kayagokalp mentioned this pull request Apr 17, 2023
Closed
@kayagokalp kayagokalp marked this pull request as ready for review April 17, 2023 11:11
sdankel
sdankel approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

mitchmindtree
mitchmindtree approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

forc-pkg/src/source/mod.rs Show resolved Hide resolved
@kayagokalp kayagokalp enabled auto-merge (squash) April 19, 2023 09:23
@kayagokalp kayagokalp enabled auto-merge (squash) April 19, 2023 10:03
@kayagokalp kayagokalp merged commit 35fe324 into master Apr 19, 2023
25 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/3958 branch April 19, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@mitchmindtree mitchmindtree mitchmindtree approved these changes

@sdankel sdankel sdankel approved these changes

@eightfilms eightfilms Awaiting requested review from eightfilms

Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forc-pkg: Support workspace-level [patch] table
5 participants
@kayagokalp @JoshuaBatty @mitchmindtree @eightfilms @sdankel