Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disallow nested packages #4407

Merged
merged 8 commits into from
Apr 13, 2023
Merged

feat: disallow nested packages #4407

merged 8 commits into from
Apr 13, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Apr 6, 2023

Description

closes #4072

Disallows package structure such as the following:

proj1
├── proj2
│   ├── Forc.lock
│   ├── Forc.toml
│   ├── out
│   └── src
├── Forc.lock
├── Forc.toml
├── out
│   └── debug
└── src
    └── main.sw

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added enhancement New feature or request forc forc-pkg Everything related to the `forc-pkg` crate. labels Apr 6, 2023
@kayagokalp kayagokalp self-assigned this Apr 6, 2023
@kayagokalp kayagokalp marked this pull request as ready for review April 7, 2023 18:06
@kayagokalp kayagokalp requested a review from a team April 7, 2023 18:07
@kayagokalp kayagokalp enabled auto-merge (squash) April 7, 2023 18:08
@kayagokalp kayagokalp marked this pull request as draft April 7, 2023 18:15
auto-merge was automatically disabled April 7, 2023 18:15

Pull request was converted to draft

@kayagokalp
Copy link
Member Author

kayagokalp commented Apr 7, 2023

blocked by #4412

@kayagokalp kayagokalp marked this pull request as ready for review April 11, 2023 22:01
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will be handy! Just a few small suggestions, otherwise lgtm

forc-util/src/lib.rs Outdated Show resolved Hide resolved
forc-util/src/lib.rs Show resolved Hide resolved
forc-util/src/lib.rs Outdated Show resolved Hide resolved
@kayagokalp kayagokalp enabled auto-merge (squash) April 12, 2023 09:17
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One last nit

forc-util/src/lib.rs Outdated Show resolved Hide resolved
@kayagokalp kayagokalp requested a review from a team April 12, 2023 15:19
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kayagokalp kayagokalp merged commit 1e63c15 into master Apr 13, 2023
@kayagokalp kayagokalp deleted the kayagokalp/4072 branch April 13, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forc forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conservatively disallow nesting a package within a package
3 participants