Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unifier generated warning spans. #4421

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Fixes unifier generated warning spans. #4421

merged 1 commit into from
Apr 10, 2023

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Apr 10, 2023 •
edited by tritao

Description

Enums and structs unify warning messages were pointing to the declared types.

With these changes the warning messages now point to the place of usage span.

Closes #3584

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal
Fixes unifier generated warning spans.
09dfb48 
Enums and structs unify warning messages were pointing to the declared types.

With these changes the warning messages now point to the place of usage span.

Closes #3584
@esdrubal esdrubal added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Apr 10, 2023
@esdrubal esdrubal self-assigned this Apr 10, 2023
@tritao tritao requested a review from a team April 10, 2023 17:18
@tritao tritao enabled auto-merge (squash) April 10, 2023 17:18
@tritao tritao merged commit 91afe69 into master Apr 10, 2023
@tritao tritao deleted the esdrubal/3584_u64_casting branch April 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

Assignees

@esdrubal esdrubal

Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Result instantiation produces suboptimal warnings
3 participants
@esdrubal @tritao @mohammadfawaz