Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intrinsics tests #4567

Merged
merged 2 commits into from
May 17, 2023
Merged

Add intrinsics tests #4567

merged 2 commits into from
May 17, 2023

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 16, 2023

Description

Add missing tests for the ir generation of all intrinsics and fix a bug in the ir printer that elided the output value for state_store_word, state_store_quad and state_load_quad.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111
Add intrinsics tests
83c1930 
Add missing tests for the ir generation of all intrinsics and fix a bug
in the ir printer that elided the output value for state_store_word,
state_store_quad and state_load_quad
@IGI-111 IGI-111 added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged testing General testing compiler: ir IRgen and sway-ir including optimization passes labels May 16, 2023
@IGI-111 IGI-111 requested a review from a team May 16, 2023 22:20
@IGI-111 IGI-111 self-assigned this May 16, 2023
@IGI-111 IGI-111 merged commit 639ae5c into master May 17, 2023
@IGI-111 IGI-111 deleted the IGI-111/intrinsics-tests branch May 17, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@vaivaswatha vaivaswatha vaivaswatha approved these changes

Assignees

@IGI-111 IGI-111

Labels
bug Something isn't working compiler: ir IRgen and sway-ir including optimization passes compiler General compiler. Should eventually become more specific as the issue is triaged testing General testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGI-111 @vaivaswatha @sdankel