Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: std publish directory #4590

Merged
merged 1 commit into from
May 27, 2023
Merged

fix: std publish directory #4590

merged 1 commit into from
May 27, 2023

Conversation

eureka-cpu
Copy link
Contributor

Description

Updates to forc doc changed the output structure of generated docs. This updates the publish directory so that mdbook can find the index.html.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@eureka-cpu eureka-cpu added bug Something isn't working ci lib: std Standard library forc-doc Everything related to the `forc doc` command plugin. labels May 26, 2023
@eureka-cpu eureka-cpu requested review from sarahschwartz and a team May 26, 2023 23:24
@eureka-cpu eureka-cpu self-assigned this May 26, 2023
@eureka-cpu eureka-cpu merged commit af07c68 into master May 27, 2023
@eureka-cpu eureka-cpu deleted the eureka-cpu/fix-std-publish-dir branch May 27, 2023 01:44
@eureka-cpu eureka-cpu restored the eureka-cpu/fix-std-publish-dir branch May 27, 2023 04:02
@eureka-cpu eureka-cpu mentioned this pull request May 27, 2023
Merged
7 tasks
eureka-cpu added a commit that referenced this pull request May 30, 2023
@eureka-cpu
fix: std publish directory -- deploy step (#4591)
fc34cb5 
## Description
I missed the deploy path in #4590 , which currently makes the
`/master/std` path break. This fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahschwartz sarahschwartz sarahschwartz approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@eureka-cpu eureka-cpu

Labels
bug Something isn't working ci forc-doc Everything related to the `forc doc` command plugin. lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eureka-cpu @sdankel @sarahschwartz