Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail formatting if there are syntax error nodes #5015

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 24, 2023

Description

This PR complements #4912.

We currently do not allow file with syntax errors to be formatted, but if the fmt was called with AST with syntax errors, it would "eat" all error spans.

Now the whole formatting will fail with a more decent error message.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Aug 24, 2023
@xunilrj xunilrj requested a review from a team August 24, 2023 07:31
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) August 24, 2023 23:36
@JoshuaBatty JoshuaBatty merged commit 2919d44 into master Aug 24, 2023
26 checks passed
@JoshuaBatty JoshuaBatty deleted the xunilrj/fail-fmt-when-error branch August 24, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants