-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework server to use experimental mutable tower-lsp branch #5057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
force-pushed
the
josh/mutable_tower_lsp
branch
from
August 30, 2023 04:05
319d339
to
4864b6e
Compare
JoshuaBatty
force-pushed
the
josh/mutable_tower_lsp
branch
from
August 30, 2023 06:30
18cae71
to
c8c0776
Compare
JoshuaBatty
force-pushed
the
josh/mutable_tower_lsp
branch
from
August 30, 2023 06:37
c8c0776
to
a26efc1
Compare
Closing as it doesn't seem like there is going to be any movement on getting this support merged in the master branch of tower-lsp. We have since optimised the server to work with references so most of the performance wins are already evident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the experimental branch in
tower-lsp
that allows notification methods to take&mut self
. This means we no longer need to wrap all of our types inRwLock
's as we have clear boundaries where we can mutate state owned by the server and where we just take a reference.Not looking to get this PR merged at this stage, just opening for visibility. I must say, it really does feel soooo much nicer than what we currently are doing. I'm going to reach out to @ebkalderon to see whats left to do before this branch can be merged into master in
tower-lsp
.See this issue for more context on the API change in
tower-lsp
Checklist
Breaking*
orNew Feature
labels where relevant.