Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework server to use experimental mutable tower-lsp branch #5057

Closed
wants to merge 18 commits into from

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Aug 30, 2023

Description

This PR uses the experimental branch in tower-lsp that allows notification methods to take &mut self. This means we no longer need to wrap all of our types in RwLock's as we have clear boundaries where we can mutate state owned by the server and where we just take a reference.

Not looking to get this PR merged at this stage, just opening for visibility. I must say, it really does feel soooo much nicer than what we currently are doing. I'm going to reach out to @ebkalderon to see whats left to do before this branch can be merged into master in tower-lsp.

See this issue for more context on the API change in tower-lsp

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty
Copy link
Member Author

Closing as it doesn't seem like there is going to be any movement on getting this support merged in the master branch of tower-lsp. We have since optimised the server to work with references so most of the performance wins are already evident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant