-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Asset Transfer and Mint Functions #5891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitzoic
added
lib: std
Standard library
breaking
May cause existing user code to break. Requires a minor or major release.
labels
Apr 23, 2024
jjcnn
approved these changes
Apr 24, 2024
K1-R1
approved these changes
Apr 25, 2024
Isnt this forcing an additional match statement for some situations that might not need one? The previous functions could have been used for gas golfing where it is known whether the transfer is going to be to a contract or address beforehand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are currently multiple functions for the same functionality:
Transfer:
transfer()
force_transfer_to_contract()
transfer_to_address()
Mint:
mint()
mint_to()
mint_to_contract()
mint_to_address()
This be reduced to just
transfer()
,mint()
,mint_to()
. Specific functions for separately minting and transferring to contracts and addresses are legacy code left over from before theIdentity
type was introduced and now only adds additional complexity.Changes:
force_transfer_to_contract()
is now privatetransfer_to_address()
is now privatemint_to_contract()
removedmint_to_address()
removedforc doc
compatibilityburn()
inline docsBreaking Changes:
force_transfer_to_contract()
is now privatetransfer_to_address()
is now privatemint_to_contract()
removedmint_to_address()
removedCloses
Checklist
Breaking*
orNew Feature
labels where relevant.