ci: add a job for checking fuel-core versions between sdk-harness and test suite #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rness and test suite
sdankel
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Was it expected to fail? https://github.com/FuelLabs/sway/actions/runs/8852823845/job/24312281868?pr=5930
It should fail as this is a current problem that we have but not like this. The script needs a little bit more attention. Currently trying to fix it locally. |
|
Looks like sway repo bumped to fuel-core already. So this should not fail |
|
97f4f20 (action link) shows it fails correctly once the versions are mismatched. |
ironcev
approved these changes
Apr 27, 2024
IGI-111
approved these changes
Apr 27, 2024
kayagokalp
deleted the
kayagokalp/fuel-core-test-suite-sdk-harness-compat-ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are currently out of sync in between sdk-harness and test suite, this is not ideal due to couple of reasons:
The added job will fail and inform the dev bumping fuel-core version, to also bump it in sdk-harness or in general make them in sync.
The reason we need this as a CI job is we cannot enforce it via cargo. Since adding sdk-harness to the sway repo workspace, it creates our well known cyclic dependency between sdk and sway. So this should be checked in CI.