-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Larger clippy::pedantic and code quality pass on whole repo #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 17605d3Click to view benchmark
|
kayagokalp
previously approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! should we also ensure this in CI?
Benchmark for 63bf457Click to view benchmark
|
Benchmark for f3d1bdfClick to view benchmark
|
Thanks, yeah I think it would be helpful to add a few more checks above what vanilla clippy gives us. Will try and find a reasonable set of suggestions to add in. |
Benchmark for 79dcce9Click to view benchmark
|
tritao
approved these changes
May 4, 2024
kayagokalp
approved these changes
May 4, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's still a ton more to do but going to open this to get merged to avoid conflicts. We can possibly add in some of these rules into CI in a future PR.
Checklist
Breaking*
orNew Feature
labels where relevant.