Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to fuel-core v0.26.0 #5981

Merged
merged 13 commits into from
May 10, 2024
Merged

Conversation

kayagokalp
Copy link
Member

Description

Bumps fuel-core to v0.26.0, for some reason sway-core was failing and needed a blanket implementation for Vec<T: PartialEqWithEngines>

@kayagokalp kayagokalp self-assigned this May 9, 2024
@kayagokalp kayagokalp added enhancement New feature or request dependencies and removed enhancement New feature or request labels May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Benchmark for 15c62e2

Click to view benchmark
Test Base PR %
code_action 5.5±0.10ms 5.3±0.01ms -3.64%
code_lens 289.0±6.58ns 287.5±7.83ns -0.52%
compile 6.7±0.10s 6.7±0.08s 0.00%
completion 5.0±0.06ms 4.8±0.12ms -4.00%
did_change_with_caching 6.1±0.05s 6.1±0.03s 0.00%
document_symbol 989.1±44.03µs 943.2±22.77µs -4.64%
format 87.8±0.69ms 78.0±1.74ms -11.16%
goto_definition 389.3±3.28µs 353.2±16.91µs -9.27%
highlight 9.1±0.02ms 8.7±0.16ms -4.40%
hover 583.7±15.28µs 586.8±9.14µs +0.53%
idents_at_position 121.3±0.92µs 122.7±1.46µs +1.15%
inlay_hints 668.7±21.99µs 641.7±24.19µs -4.04%
on_enter 522.0±11.32ns 472.7±12.87ns -9.44%
parent_decl_at_position 3.7±0.03ms 3.6±0.04ms -2.70%
prepare_rename 349.7±5.91µs 345.1±6.77µs -1.32%
rename 9.6±0.07ms 9.3±0.09ms -3.12%
semantic_tokens 1046.9±22.01µs 1069.6±19.20µs +2.17%
token_at_position 346.2±2.52µs 347.7±2.73µs +0.43%
tokens_at_position 3.7±0.03ms 3.6±0.07ms -2.70%
tokens_for_file 415.9±2.49µs 416.8±4.20µs +0.22%
traverse 50.8±1.34ms 51.0±1.49ms +0.39%

Copy link

github-actions bot commented May 9, 2024

Benchmark for e72a0f8

Click to view benchmark
Test Base PR %
code_action 5.4±0.04ms 5.3±0.12ms -1.85%
code_lens 289.3±7.44ns 311.4±5.43ns +7.64%
compile 3.3±0.04s 3.3±0.03s 0.00%
completion 4.7±0.05ms 4.6±0.02ms -2.13%
did_change_with_caching 2.9±0.03s 2.8±0.04s -3.45%
document_symbol 1018.0±28.30µs 956.6±22.86µs -6.03%
format 91.2±0.71ms 71.3±1.37ms -21.82%
goto_definition 358.0±3.87µs 367.9±5.80µs +2.77%
highlight 9.1±0.03ms 8.7±0.14ms -4.40%
hover 482.4±10.27µs 487.2±27.16µs +1.00%
idents_at_position 122.4±0.33µs 123.3±1.23µs +0.74%
inlay_hints 667.6±25.15µs 654.9±25.00µs -1.90%
on_enter 499.4±10.74ns 474.8±9.70ns -4.93%
parent_decl_at_position 3.8±0.06ms 3.6±0.04ms -5.26%
prepare_rename 361.7±5.61µs 372.7±13.73µs +3.04%
rename 9.8±0.97ms 9.3±0.32ms -5.10%
semantic_tokens 1030.9±10.40µs 1045.6±23.46µs +1.43%
token_at_position 362.4±1.89µs 359.8±1.87µs -0.72%
tokens_at_position 3.8±0.08ms 3.6±0.08ms -5.26%
tokens_for_file 433.2±3.83µs 431.9±1.86µs -0.30%
traverse 39.8±1.07ms 40.3±1.55ms +1.26%

Copy link

Benchmark for fee85c8

Click to view benchmark
Test Base PR %
code_action 5.4±0.04ms 5.2±0.05ms -3.70%
code_lens 296.5±10.28ns 312.7±8.18ns +5.46%
compile 3.5±0.04s 3.4±0.04s -2.86%
completion 4.7±0.07ms 4.6±0.09ms -2.13%
did_change_with_caching 2.9±0.02s 2.9±0.04s 0.00%
document_symbol 991.9±20.71µs 1008.8±35.25µs +1.70%
format 91.1±1.46ms 71.3±0.89ms -21.73%
goto_definition 357.2±6.85µs 373.7±7.90µs +4.62%
highlight 9.1±0.11ms 8.7±0.18ms -4.40%
hover 491.4±41.29µs 485.0±6.28µs -1.30%
idents_at_position 121.9±0.29µs 124.0±0.43µs +1.72%
inlay_hints 670.3±26.07µs 657.9±26.16µs -1.85%
on_enter 503.9±14.26ns 481.4±14.24ns -4.47%
parent_decl_at_position 3.7±0.02ms 3.6±0.04ms -2.70%
prepare_rename 359.9±6.98µs 369.8±12.78µs +2.75%
rename 9.7±0.04ms 9.3±0.32ms -4.12%
semantic_tokens 1044.6±36.22µs 1035.9±16.92µs -0.83%
token_at_position 358.5±1.71µs 357.5±5.95µs -0.28%
tokens_at_position 3.7±0.02ms 3.6±0.06ms -2.70%
tokens_for_file 455.4±2.74µs 418.9±2.90µs -8.01%
traverse 40.4±1.38ms 40.7±0.82ms +0.74%

@kayagokalp kayagokalp requested review from a team May 10, 2024 01:02
@kayagokalp kayagokalp enabled auto-merge (squash) May 10, 2024 01:03
Copy link

Benchmark for d8fc702

Click to view benchmark
Test Base PR %
code_action 5.5±0.01ms 5.2±0.02ms -5.45%
code_lens 298.0±8.20ns 302.4±9.25ns +1.48%
compile 3.4±0.06s 3.4±0.04s 0.00%
completion 4.8±0.07ms 4.6±0.05ms -4.17%
did_change_with_caching 2.8±0.06s 2.8±0.05s 0.00%
document_symbol 1010.3±38.93µs 954.4±38.72µs -5.53%
format 90.7±1.72ms 71.0±1.33ms -21.72%
goto_definition 396.4±5.17µs 372.6±12.43µs -6.00%
highlight 9.1±0.11ms 8.7±0.17ms -4.40%
hover 526.3±5.46µs 493.2±6.50µs -6.29%
idents_at_position 122.7±0.29µs 124.5±0.71µs +1.47%
inlay_hints 675.5±25.30µs 645.8±28.25µs -4.40%
on_enter 504.4±11.93ns 476.5±10.13ns -5.53%
parent_decl_at_position 3.7±0.06ms 3.6±0.04ms -2.70%
prepare_rename 404.2±5.05µs 365.6±6.28µs -9.55%
rename 9.7±0.02ms 9.3±0.38ms -4.12%
semantic_tokens 1030.2±51.47µs 1042.4±18.26µs +1.18%
token_at_position 393.4±2.98µs 355.4±2.43µs -9.66%
tokens_at_position 3.7±0.03ms 3.6±0.10ms -2.70%
tokens_for_file 425.9±7.59µs 419.1±1.82µs -1.60%
traverse 40.7±1.86ms 41.0±1.45ms +0.74%

@JoshuaBatty JoshuaBatty requested review from a team May 10, 2024 03:15
Copy link

Benchmark for b0a861d

Click to view benchmark
Test Base PR %
code_action 5.6±0.27ms 5.4±0.09ms -3.57%
code_lens 289.3±7.28ns 298.6±9.46ns +3.21%
compile 3.3±0.25s 3.0±0.05s -9.09%
completion 4.6±0.02ms 4.7±0.08ms +2.17%
did_change_with_caching 2.8±0.03s 2.9±0.06s +3.57%
document_symbol 1024.0±26.07µs 963.0±36.77µs -5.96%
format 93.0±1.37ms 70.7±1.01ms -23.98%
goto_definition 357.6±4.02µs 366.5±8.65µs +2.49%
highlight 8.7±0.10ms 9.1±0.01ms +4.60%
hover 487.5±36.33µs 484.8±6.26µs -0.55%
idents_at_position 122.4±0.43µs 122.8±1.82µs +0.33%
inlay_hints 657.6±9.09µs 664.5±16.04µs +1.05%
on_enter 493.4±11.50ns 507.4±28.38ns +2.84%
parent_decl_at_position 3.6±0.10ms 3.7±0.04ms +2.78%
prepare_rename 360.7±5.91µs 367.2±5.68µs +1.80%
rename 9.2±0.07ms 10.2±0.12ms +10.87%
semantic_tokens 1028.5±15.74µs 1064.8±12.67µs +3.53%
token_at_position 359.7±5.35µs 361.2±3.99µs +0.42%
tokens_at_position 3.6±0.03ms 3.7±0.07ms +2.78%
tokens_for_file 447.0±3.45µs 423.9±2.73µs -5.17%
traverse 42.1±1.90ms 42.6±1.08ms +1.19%

@kayagokalp kayagokalp merged commit fc4007d into master May 10, 2024
38 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/fuel-core-0.26.0 branch May 10, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants