Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clap and deps to latest version #5994

Merged
merged 2 commits into from
May 14, 2024
Merged

Update clap and deps to latest version #5994

merged 2 commits into from
May 14, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 13, 2024

Description

Update clap and deps to latest version

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

Benchmark for c99ce54

Click to view benchmark
Test Base PR %
code_action 5.4±0.08ms 5.4±0.09ms 0.00%
code_lens 317.5±6.86ns 311.6±11.19ns -1.86%
compile 2.9±0.02s 3.0±0.04s +3.45%
completion 4.7±0.06ms 4.8±0.16ms +2.13%
did_change_with_caching 2.8±0.05s 2.8±0.05s 0.00%
document_symbol 973.6±15.86µs 995.4±31.80µs +2.24%
format 70.7±0.93ms 77.3±1.09ms +9.34%
goto_definition 360.8±5.60µs 372.6±7.24µs +3.27%
highlight 9.0±0.01ms 9.2±0.15ms +2.22%
hover 478.5±6.27µs 491.3±6.29µs +2.68%
idents_at_position 122.0±0.34µs 124.1±0.66µs +1.72%
inlay_hints 667.0±16.74µs 670.5±10.14µs +0.52%
on_enter 509.5±12.85ns 498.6±17.53ns -2.14%
parent_decl_at_position 3.7±0.05ms 3.8±0.03ms +2.70%
prepare_rename 361.0±5.97µs 369.5±6.44µs +2.35%
rename 9.7±0.30ms 9.7±0.08ms 0.00%
semantic_tokens 1020.2±19.41µs 1064.5±18.43µs +4.34%
token_at_position 354.5±3.47µs 363.3±3.47µs +2.48%
tokens_at_position 3.7±0.03ms 3.8±0.03ms +2.70%
tokens_for_file 425.3±2.71µs 434.2±2.80µs +2.09%
traverse 39.9±1.13ms 40.7±0.96ms +2.01%

Copy link

Benchmark for 5a42737

Click to view benchmark
Test Base PR %
code_action 5.4±0.01ms 5.5±0.09ms +1.85%
code_lens 300.6±24.03ns 296.9±8.44ns -1.23%
compile 2.9±0.02s 2.9±0.04s 0.00%
completion 4.7±0.01ms 4.7±0.04ms 0.00%
did_change_with_caching 2.8±0.05s 2.8±0.03s 0.00%
document_symbol 962.1±17.64µs 977.3±52.55µs +1.58%
format 72.0±0.80ms 77.4±1.23ms +7.50%
goto_definition 360.3±4.11µs 362.6±6.82µs +0.64%
highlight 9.1±0.10ms 9.1±0.08ms 0.00%
hover 475.8±6.73µs 480.9±7.56µs +1.07%
idents_at_position 122.0±0.29µs 124.6±0.42µs +2.13%
inlay_hints 696.1±7.18µs 671.5±22.94µs -3.53%
on_enter 507.7±14.43ns 500.1±9.87ns -1.50%
parent_decl_at_position 3.8±0.04ms 3.8±0.02ms 0.00%
prepare_rename 356.7±6.60µs 362.6±8.21µs +1.65%
rename 9.6±0.08ms 9.8±0.73ms +2.08%
semantic_tokens 1026.5±19.08µs 1056.7±18.30µs +2.94%
token_at_position 351.9±2.66µs 361.9±7.46µs +2.84%
tokens_at_position 3.8±0.01ms 3.8±0.18ms 0.00%
tokens_for_file 431.5±1.39µs 427.6±4.07µs -0.90%
traverse 40.7±1.25ms 40.4±1.08ms -0.74%

@IGI-111 IGI-111 marked this pull request as ready for review May 13, 2024 06:04
@IGI-111 IGI-111 requested review from a team May 13, 2024 06:04
@IGI-111 IGI-111 self-assigned this May 13, 2024
tritao
tritao previously approved these changes May 13, 2024
JoshuaBatty
JoshuaBatty previously approved these changes May 13, 2024
@IGI-111 IGI-111 dismissed stale reviews from JoshuaBatty and tritao via 8e6edec May 14, 2024 05:53
Copy link

Benchmark for 63ceb6e

Click to view benchmark
Test Base PR %
code_action 5.3±0.02ms 5.2±0.10ms -1.89%
code_lens 329.4±11.65ns 299.5±6.68ns -9.08%
compile 2.9±0.04s 2.9±0.03s 0.00%
completion 4.7±0.07ms 4.6±0.07ms -2.13%
did_change_with_caching 2.8±0.03s 2.8±0.05s 0.00%
document_symbol 971.3±21.94µs 947.1±17.90µs -2.49%
format 89.2±1.56ms 70.6±1.21ms -20.85%
goto_definition 353.0±5.31µs 369.7±8.51µs +4.73%
highlight 9.0±0.11ms 8.8±0.19ms -2.22%
hover 468.1±6.53µs 493.3±6.08µs +5.38%
idents_at_position 122.4±0.31µs 122.5±0.37µs +0.08%
inlay_hints 671.2±13.85µs 664.8±23.58µs -0.95%
on_enter 486.3±12.16ns 486.1±11.61ns -0.04%
parent_decl_at_position 3.7±0.09ms 3.6±0.03ms -2.70%
prepare_rename 351.9±5.53µs 370.2±6.88µs +5.20%
rename 9.6±0.12ms 9.3±0.15ms -3.12%
semantic_tokens 1015.6±10.82µs 1050.3±17.01µs +3.42%
token_at_position 351.4±2.81µs 371.7±2.61µs +5.78%
tokens_at_position 3.7±0.03ms 3.6±0.04ms -2.70%
tokens_for_file 415.7±1.29µs 434.6±2.53µs +4.55%
traverse 40.7±1.34ms 40.7±1.15ms 0.00%

@IGI-111 IGI-111 requested review from tritao, JoshuaBatty and a team May 14, 2024 07:21
@kayagokalp kayagokalp requested a review from a team May 14, 2024 07:23
@IGI-111 IGI-111 merged commit 3c86abb into master May 14, 2024
38 checks passed
@IGI-111 IGI-111 deleted the IGI-111/update_clap branch May 14, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants