Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show forc plugin path warning only in verbose mode #6004

Merged
merged 7 commits into from
May 24, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented May 13, 2024

Description

This warning is mostly unnecessary. For fuelup users, it's expected that they might install some forc plugins outside of fuelup (with rust, nix, npm, etc.). For pure nix users, the paths will always be different, for example:

warning: The fmt (/nix/store/hwd7z0zyfvk331vfiqg87sqsq5aqss43-forc-fmt-0.56.0/bin/forc-fmt) plugin is in a different directory than forc (/nix/store/i0zn8pw77a7zrxm4b7jbz1b1x8cglc0f-forc-0.56.0/bin/forc)

We can either keep it and only show it when --verbose is passed, or remove it entirely.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review May 13, 2024 22:42
@sdankel sdankel enabled auto-merge (squash) May 13, 2024 22:43
@sdankel sdankel changed the title Remove forc plugin path warning Show forc plugin path warning only in verbose mode May 13, 2024
@sdankel sdankel disabled auto-merge May 13, 2024 22:58
@sdankel sdankel requested a review from a team May 13, 2024 22:58
@sdankel sdankel enabled auto-merge (squash) May 23, 2024 15:25
@sdankel sdankel merged commit 3f4b971 into master May 24, 2024
32 of 33 checks passed
@sdankel sdankel deleted the sophie/remove-plugin-path-warning branch May 24, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants