Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set code owners #6078

Merged
merged 2 commits into from
May 31, 2024
Merged

Set code owners #6078

merged 2 commits into from
May 31, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 31, 2024 •
edited
Loading

Description

We recently identified that our review process is a potential security vulnerability, so we want to enforce that code changes are reviewed by people who understand the code that has been changed, as well as enforce that version bumps and releases are only done by a restricted group of people.

This change is a first step towards that by setting the code owners to reasonable values on the repository.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 requested review from JoshuaBatty and a team May 31, 2024 04:34
bitzoic
bitzoic previously approved these changes May 31, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@IGI-111 IGI-111 force-pushed the IGI-111/add-code-owners branch 2 times, most recently from f7a368d to cf3ca9c Compare May 31, 2024 04:40
@IGI-111 IGI-111 requested a review from a team May 31, 2024 04:40
@IGI-111
Set code owners
6ae3f2b 
We recently identified that our review process is a potential security
vulnerability, so we want to enforce that code changes are reviewed by
people who understand the code that has been changed, as well as enforce
that version bumps and releases are only done by a restricted group of
people.

This change is a first step towards that by setting the code owners to
reasonable values on the this repository.
@IGI-111 IGI-111 merged commit d0ef108 into master May 31, 2024
37 checks passed
@IGI-111 IGI-111 deleted the IGI-111/add-code-owners branch May 31, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@xunilrj xunilrj xunilrj approved these changes

@bitzoic bitzoic bitzoic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IGI-111 @xunilrj @JoshuaBatty @bitzoic