Do not panic when there is auto impl type check #6094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix #6093.
The cause seems to be a problem with our error reporting. What is happening is, the source code has other errors unrelated to auto impl of AbiEncode. For example, some private fields are being accessed from other modules.
This is currently panicking because when type-checking the auto impl, some of these errors "leak" into the auto impl
type_check
and make it fail completely; I was expecting the type check would always finish, even if with some errors.This was being used as a security guard against implementation bugs. But now that the auto impl is more stable we can remove it, and when a type check completely fails, we do not panic anymore, just failing that particular auto impl.
Checklist
Breaking*
orNew Feature
labels where relevant.