Provision IR for future storage API. #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch `load` and `store` instructions to use a Value for the source
or destination.
- Instead of accessing a Pointer directly the use of a `get_ptr`
instruction is now mandated.
- Introduct a `ptr_cast` operation which casts the type of a pointer
and may also be passed to `load` and `store`.
- Add `state_load` and `state_store` which take a `b256` key and read or
write either `u64` or `b256` values from or to memory.
- Change the serialised syntax a little bit, update the tests.
- `load` and `store` must now take a value as the address arg. - Add stubs to ASMgen for the yet to be utilised `ptr_cast`, `state_load` and `state_store` IR operations. - Update the tests for the new `load` and `store`.
otrho
added
enhancement
|
Should we wait for #646 to go in so that we can test these changes all the way through ASM? |
|
#646 is two things back in my queue right now, I say we take this first and follow up with a smaller PR hooking the front end up to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability implement the storage instructions via IR. They're not exercised at all yet, other than a little IR test, but not all the way to ASM. Once #646 is done we can do it then.
Closes #856. Will probably conflict with #857.