Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault inflation attack #541

Merged
merged 41 commits into from
May 22, 2023
Merged

Vault inflation attack #541

merged 41 commits into from
May 22, 2023

Conversation

pedrovalido
Copy link
Contributor

@pedrovalido pedrovalido commented May 18, 2023 •
edited by 0xdcota
Loading

This pull request addresses vulnerabilities M-1 of Macro audit report.

@pedrovalido pedrovalido added Bug Something isn't working Smart Contracts labels May 18, 2023
@pedrovalido pedrovalido self-assigned this May 18, 2023
@pedrovalido pedrovalido changed the base branch from main to protocol/fix/macro-findings-medium May 18, 2023 13:51
@pedrovalido pedrovalido marked this pull request as draft May 18, 2023 13:51
pedrovalido and others added 17 commits May 18, 2023 20:07
@pedrovalido
feat(protocol): add usdt on mainnet
a640ef4
@pedrovalido
fix(protocol): adapt setup to initialize vaults, add helper functions…
3811378 
… and variables
@pedrovalido
fix(protocol): dealing mockerc20
4227af3
@pedrovalido
fix(protocol): adapt asserts to initializeVaultShares
8393736
@pedrovalido
fix(protocol): use secure increaseAllowance
122e681
@pedrovalido
fix(protocol): initialize vaults when deploying
9ba062b
@pedrovalido
fix(protocol): use secure increaseAllowance
2641dac
@pedrovalido
fix(protocol): calculate minimum collateral to support initialize wit…
6d7390e 
…h min debt
@pedrovalido
fix(protocol): adapt asserts to initializeVaultShares
49c7459
@pedrovalido
fix(protocol): min collateral calculation, assets being used to calcu…
1fb7faf 
…late
@pedrovalido
fix(protocol): remove todo comment because its done
a568471
@pedrovalido
fix(protocol): contract name
3ad2cff
@pedrovalido
fix(protocol): use initializer instead of forking contract
3167114
@pedrovalido
fix(protocol): incorrect contracts for mainnet
4d26747
@pedrovalido
fix(protocol): use secure increaseAllowance
136026e
@0xdcota
fix(protocol): tests for mocking simple router
6059c85
@0xdcota
fix(protocol): forking tests simple router
b94d7a6
pedrovalido and others added 15 commits May 21, 2023 17:34
@pedrovalido
fix(protocol): get decimals from variable
2ce8574
@0xdcota
Merge branch 'protocol/fix/vault-inflation-attack' into protocol/fix/…
bae6b40 
…vault-inflation-attack-test
@0xdcota
fix(protocol): yield vault init with asset arg
4546446
@0xdcota
chore(protocol): use deal with true arg
eef8a60
@0xdcota
chore(protocol): update mocking tests
b42959f
@pedrovalido
fix(protocol): adapt asserts to initializeVaultShares
02e0702
@pedrovalido
fix(protocol): adapt asserts to initializeVaultShares
997326e
@0xdcota
Merge branch 'protocol/fix/vault-inflation-attack' into protocol/fix/…
b52a59b 
…vault-inflation-attack-test
@0xdcota
fix(protocol): remove true from deal in forking
b0f3e14
@pedrovalido
fix(protocol): use initVaultShares from function
3c53756
@0xdcota
chore(protocol): forking setup initializer with 2 multiplier
0ec3419
@0xdcota
chore(protocol): update test get balance wepiggy polygon
9d5986b
@pedrovalido
fix(protocol): use compounds baseBorrowMin to initialize vault
1059c17
@pedrovalido
fix(protocol): adapt vault ltv to wepiggy to be able to test
9e20879
@pedrovalido
fix(protocol): use minCollateralAmount, multiplier no longer needed
6a7b37f
@0xdcota 0xdcota self-requested a review May 22, 2023 14:48
@0xdcota 0xdcota marked this pull request as ready for review May 22, 2023 14:49
@0xdcota 0xdcota merged commit c53516c into protocol/fix/macro-findings-medium May 22, 2023
@0xdcota 0xdcota deleted the protocol/fix/vault-inflation-attack branch May 22, 2023 14:50
@0xdcota 0xdcota mentioned this pull request May 22, 2023
Closed
@0xdcota 0xdcota linked an issue May 22, 2023 that may be closed by this pull request
M-1 Remaining inflation attack #448
Closed
@0xdcota 0xdcota mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdcota 0xdcota Awaiting requested review from 0xdcota

Assignees

@pedrovalido pedrovalido

Labels
Bug Something isn't working Smart Contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M-1 Remaining inflation attack
2 participants
@pedrovalido @0xdcota