Skip to content

fix(tube): move the getOrCreatChan outside of the goroutine #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2024
Merged

fix(tube): move the getOrCreatChan outside of the goroutine #161

merged 4 commits into from
Mar 21, 2024

Conversation

wyyolo
Copy link
Contributor

@wyyolo wyyolo commented Mar 14, 2024 •
edited
Loading

No description provided.

@wyyolo wyyolo changed the title fix : release should not be called within NewSinkTube, and the getOrCreateChan logic should be modified fix : release should not be called within NewSourceTube, and the getOrCreateChan logic should be modified Mar 14, 2024
RobertIndie
RobertIndie requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed atomic.AddInt32(&q.refCnt, 1) which will lead the reference count not working.

@wyyolo
Copy link
Contributor Author

wyyolo commented Mar 14, 2024

Sorry, this may have been deleted by mistake.

@wyyolo wyyolo marked this pull request as draft March 14, 2024 15:11
@wyyolo wyyolo closed this Mar 17, 2024
@wyyolo wyyolo reopened this Mar 17, 2024
@wyyolo wyyolo changed the title fix : release should not be called within NewSourceTube, and the getOrCreateChan logic should be modified fix : In NewSourceTube, move the getOrCreatChan of goroutine to the outside Mar 17, 2024
@wyyolo wyyolo marked this pull request as ready for review March 17, 2024 11:39
@RobertIndie RobertIndie changed the title fix : In NewSourceTube, move the getOrCreatChan of goroutine to the outside fix : move the getOrCreatChan outside of the goroutine Mar 21, 2024
@RobertIndie RobertIndie merged commit a13633b into FunctionStream:main Mar 21, 2024
@RobertIndie RobertIndie changed the title fix : move the getOrCreatChan outside of the goroutine fix(tube): move the getOrCreatChan outside of the goroutine Mar 21, 2024
@wyyolo wyyolo deleted the fix branch March 22, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyyolo @RobertIndie