abstract enum pagename #2451
Merged
abstract enum pagename #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should make adding modded optionspages better and easier makes it so you dont have to leech off an unused PageName or write your own code for making modded options, helping with compatibility between mods.
|
please 🙏 i wanna be able to make options pages in scripts and not do it jankily |
|
Will do a bunch more PR review tomorrow, if this doesn't immediately break the options menu then it should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns PageName into an abstract enum, which should make adding custom options pages easier and allow for more compatibility between mods that would like to add custom options pages, as they won't have to leech off an existing, unused PageName (like CoolHUD does) and also won't have to rewrite code related to options to add a custom page in a more compatible way.
Note that this will break current mods that add custom options, though