Fix duplicate combo counter on combo break #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hundrec
changed the title
EliteMasterEric
added
status: pending triage
ninjamuffin99
force-pushed
the
develop
branch
2 times, most recently
from
e0b1b01
to
410cfe9
Compare
EliteMasterEric
force-pushed
the
patch-2
branch
from
9955683
to
295348d
Compare
EliteMasterEric
added
status: accepted
Co-authored-by: Eric <ericmyllyoja@gmail.com> Co-authored-by: Hundrec <hundrecard@gmail.com>
EliteMasterEric
force-pushed
the
patch-2
branch
from
295348d
to
46c931f
Compare
|
After multiple attempts, I successfully managed to squash this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the function onNoteMiss calls applyScore, creating two sets of "000" whenever a note goes off the screen with a combo of 10 or more.
Also removes the "== 0" condition from popUpScore to prevent double displays after Bad or Shit ratings.
Subsequently, this PR removes the "000" display after getting a Bad or Shit rating with a combo of less than 10.
Question for the devs:
Do you intend for the "000" to appear after every Bad and Shit rating regardless of your combo?
Original Behavior (0.5.0)
Double combo break display
0.4.1.double.combo.break.display.mp4
Combo break display when combo <10 (bad/shit ratings but not for misses)
0.4.1.bad.shit.0.display.mp4
Pull Request Behavior
Fixed double combo break display
PR.double.combo.break.display.mp4
Combo break no longer displays when combo <10
PR.remove.bad.shit.0.display.mp4