[ENHANCEMENT] Implement a better Strumline Note Confirm Animation #2864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opponent strumline notes confirm animation were too long and didn't looked great. I increased
CONFIRM_HOLD_TIME
up to 0.15 and start the timer right when the animation is started and not when finished, just for opponents/botplay, the player confirm animation is almost the same, i just fixed a premature static animation playing when hitting a double note.resumed list:
Sorry for not being able to provide a video comparation but i couldnt record it properly