Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Implement a better Strumline Note Confirm Animation #2864

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gamerbross
Copy link
Contributor

@gamerbross gamerbross commented Jun 20, 2024

The opponent strumline notes confirm animation were too long and didn't looked great. I increased CONFIRM_HOLD_TIME up to 0.15 and start the timer right when the animation is started and not when finished, just for opponents/botplay, the player confirm animation is almost the same, i just fixed a premature static animation playing when hitting a double note.

resumed list:

  • Opponent/Botplay strumline notes confirm animation is stopped earlier so it looks nicer (by starting the stop timer when playing the confirm animation and not when finishing it)
  • Player/controlled strumline notes confirm animation is a little bit longer so it doesnt start the "press" animation too early and look weird.

Sorry for not being able to provide a video comparation but i couldnt record it properly

@gamerbross gamerbross changed the base branch from main to develop June 20, 2024 06:27
@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jun 20, 2024
@EliteMasterEric
Copy link
Member

Note to self, this makes the same change as #2522.

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. scoring Issue or PR involves the game's ranking and scoring systems. status: reviewing internally This PR is under internal review and quality assurance testing and removed status: pending triage The bug or PR has not been reviewed yet. labels Jun 29, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added the small A small pull request with 10 or fewer changes label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scoring Issue or PR involves the game's ranking and scoring systems. small A small pull request with 10 or fewer changes status: reviewing internally This PR is under internal review and quality assurance testing type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants