Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Story Mode Menu Mouse Scrolling #2873

Conversation

JVNpixels
Copy link
Contributor

Adds the ability to scroll in the StoryMenuState.

This pull request adds the ability for scrolling in the story mode menu, and it would be a good quality of life feature.

@Raltyro
Copy link

Raltyro commented Jun 21, 2024

wait in html5 it adds scrolls by 8 instead of just one?

@JVNpixels
Copy link
Contributor Author

JVNpixels commented Jun 21, 2024

Yea, Thats what the HTML5 code says for some reason.

Co-authored-by: gamerbross <55158797+gamerbross@users.noreply.github.com>
@JVNpixels
Copy link
Contributor Author

Comment has been removed.

@JVNpixels
Copy link
Contributor Author

Is this good enough to merge?

source/funkin/ui/story/StoryMenuState.hx Outdated Show resolved Hide resolved
Removes the extra line in code.
@JVNpixels
Copy link
Contributor Author

All should be fixed now!

@JVNpixels JVNpixels changed the title FIXED PULL REQUEST: Story Mode Menu Mouse Scrolling [ENHANCEMENT]: Story Mode Menu Mouse Scrolling Jun 23, 2024
@EliteMasterEric EliteMasterEric added type: enhancement Provides an enhancement or new feature. status: pending triage The bug or PR has not been reviewed yet. labels Jun 23, 2024
@EliteMasterEric
Copy link
Member

image

gamerbross approved that's how you know it's good

@EliteMasterEric
Copy link
Member

Recording.2024-06-29.01-17-16.mp4

10/10 peak content right here

@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jun 29, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jun 29, 2024
@JVNpixels
Copy link
Contributor Author

Thank you!

@JVNpixels
Copy link
Contributor Author

Just to clarify, have these been merged yet or will this be for later updates?
Milestone / Goal: 0.5 or next update.

@NotHyper-474
Copy link
Contributor

Generally when they accept it they merge it internally (as in merging into their ultra duper secret mirror repo)

@EliteMasterEric EliteMasterEric added the small A small pull request with 10 or fewer changes label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@koueu
Copy link

koueu commented Aug 24, 2024

is there a way to add the scroll as a bind in control.hx so it works on all menus?

@koueu
Copy link

koueu commented Aug 24, 2024

image
like is there a action.ui_down_alt or anything similar

@JVNpixels
Copy link
Contributor Author

I'm not sure, but they don't have mouse support for everything yet. Only the FreePlay or Story Mode if this PR gets merged next update.

@AbnormalPoof
Copy link
Contributor

if this PR gets merged next update.

Generally, PRs with the status: accepted label are set to be merged in the next update (0.5.0, as dictated by the milestone). So yes, it should be in the next update.

@JVNpixels
Copy link
Contributor Author

Yo it is in the game!

@EliteMasterEric EliteMasterEric merged commit 519a6f3 into FunkinCrew:develop Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small A small pull request with 10 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants