New settings widgets (Number, Checkbox, Enum) #2942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the checkbox settings widget into its own thing (
CheckboxPreferenceItem
) and adds aNumberPreferenceItem
and anEnumPreferenceItem
Code usage examples:
* The callbacks get called every time the player changes the value, mainly for you to update the value inside
Preferences
, but its possible to use them for example to play a sound effect to let the user preview the volume of a sound every time they change the volumeThis PR splits off features from #2793 as requested by @EliteMasterEric
Part of
NumberPreferenceItem
was implemented by @lemz1