Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login intent Id TTL to tenant configuration #286

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Add login intent Id TTL to tenant configuration #286

merged 7 commits into from
Oct 17, 2024

Conversation

spwitt
Copy link
Contributor

@spwitt spwitt commented Jun 21, 2024 •
edited
Loading

@spwitt spwitt requested a review from mmanes June 21, 2024 18:12
@spwitt spwitt changed the title Add completion token Id TTL to tenant configuration Add login intent Id TTL to tenant configuration Jun 27, 2024
@spwitt spwitt marked this pull request as ready for review October 17, 2024 19:07
@spwitt
Copy link
Contributor Author

spwitt commented Oct 17, 2024

There a linter error because it does not see the new field in the Go client.

Error: fusionauth/resource_fusionauth_tenant_helpers.go:495:92: t.ExternalIdentifierConfiguration.LoginIntentTimeToLiveInSeconds undefined (type "github.com/FusionAuth/go-client/pkg/fusionauth".ExternalIdentifierConfiguration has no field or method LoginIntentTimeToLiveInSeconds)) (typecheck)

But the field exists on main in fusionauth-go-client.

@spwitt spwitt merged commit 6a77dce into main Oct 17, 2024
1 check passed
@spwitt spwitt deleted the spencer/eng-988/completion-token branch October 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanes mmanes mmanes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spwitt @mmanes