Fix sorting of versions making RC tags the latest compared to "real" tags #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now versions are sorted properly when -RC* are added to a tag. To fix this, an underscore was added to the list of tags and then removed after the sort. The underscore comes after hyphern in terms of sorting.
|
Great! Thanks! |
|
Version 0.5.1 generated: https://github.com/Fylhan/qompoter/releases/tag/v0.5.1 Thanks @mlitre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, the sorting mechanism would not work correctly with alpha, beta or release candidate tags. These tags would appear as the "latest" tag meaning that, for example, a v4.0.0-RC1 would be chosen before a v4.0.0 tag.
To fix this, the sorting was done after adding .0_ to all tags without hyphens. By doing so, they would appear after the RC tags since the underscore comes after hyphen when use version sort.
Modifications to the tests were done accordingly.