Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to resize window that overflows #113

Closed
mattboll opened this issue May 15, 2020 · 7 comments
Closed

Allow to resize window that overflows #113

mattboll opened this issue May 15, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request Hacktoberfest

Comments

@mattboll
Copy link
Contributor

sometimes windows are too big for the screen (an other issue could be open for that)
AFAIK there is only one way to reduce height of window, and if the bottom bar is out of the screen because the app overflows, then we can't do it anymore.

We could add a shortcut such as alt-click or alt-F7 to move window over the top to be able to grab the bottom or we could allow to grab the top border to resize.

Both solution should be implemented from my point of view

@andydotxyz andydotxyz added the enhancement New feature or request label Jun 30, 2020
@andydotxyz andydotxyz added this to the 0.2 Awesome stuff milestone Jun 30, 2020
@andydotxyz
Copy link
Contributor

Probably best addresed by allowing top-left/top/top-right drag handles

@andydotxyz
Copy link
Contributor

Probably even just top left/top right would be ok, then it won’t risk interfering with the titlebar buttons

andydotxyz added a commit that referenced this issue Jan 30, 2021
Just a narrow strip, avoiding buttons.
FIxes #113
@andydotxyz andydotxyz self-assigned this Jan 30, 2021
andydotxyz added a commit that referenced this issue Feb 8, 2021
Just a narrow strip, avoiding buttons.
FIxes #113
@andydotxyz
Copy link
Contributor

Landed, now on develop for testing

@mattboll
Copy link
Contributor Author

mattboll commented Feb 9, 2021

It works pretty well, I can resize with top right corner.

But resizing brave window (should be the same with chrome browser) it moves my slack window, which is weird. Evenmore, my slack window moved to the top, over the top of the screen and then I was unable to move the slack window anymore because the top bar wasn't visible.
And after a few minutes, fynedesk just crashed

@andydotxyz
Copy link
Contributor

Is Chrome / Brave using the system borders?
I cannot replicate this with them on or off in Chrome.

@mattboll
Copy link
Contributor Author

Without system borders. I was also able to move slack window by moving brave window. I clic on the brave top bar (stay clicked) move around the window and slack window moves too, so it may be totally unrelated to this issue

@andydotxyz
Copy link
Contributor

I think that is probably related to the window-order fixes that @okratitan put in place to fix the DnD issues in Chrome.
As I'm pretty sure it is not related to this I will close the issue as complete (because this only affected system borders).
After the #156 is landed can you please test again and open a new ticket if the wrong windows are still moving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants