RF: in list of files, link to tree (not commit) for submodules #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While navigating files it makes more sense to jump to that specific state of the tree instead of specific commit diff. With such trivial change we should be able to achive that. In other similar uses of /commit/ I left them as is since there it does makes more sense to jump to diff. Inspired by @Aksoo
mpsonntag
requested changes
Jun 21, 2022
| @@ -9,7 +9,7 @@ | |||
| <img class="ui avatar image img-12" src="{{AvatarLink .LatestCommit.Author.Email}}" /> | |||
| <strong>{{.LatestCommit.Author.Name}}</strong> | |||
| {{end}} | |||
| <a rel="nofollow" class="ui sha label" href="{{.RepoLink}}/commit/{{.LatestCommit.ID}}" rel="nofollow">{{ShortSHA1 .LatestCommit.ID.String}}</a> | |||
| <a rel="nofollow" class="ui sha label" href="{{.RepoLink}}/tree/{{.LatestCommit.ID}}" rel="nofollow">{{ShortSHA1 .LatestCommit.ID.String}}</a> | |||
There was a problem hiding this comment.
I don't think .../tree/... is supported with our current version of gogs. I think the appropriate change would be .../src/... to achieve the required result.
There was a problem hiding this comment.
Also this change affects general files and is not submodule specific as the PR title describes. Submodule specific code starts from line 30 onwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While navigating files it makes more sense to jump to that specific
state of the tree instead of specific commit diff. With such trivial
change we should be able to achive that. In other similar uses of /commit/
I left them as is since there it does makes more sense to jump to diff.
Inspired by @Aksoo