Value Reordering #179

fschrader1992 · 2020-06-18T20:43:09Z

This PR:

Fixes the error on multi value reordering. Closes Error on value reordering #141
Fixes the error when deleting empty/the first of two multi values. Closes Background error on empty value remove #137
Prohibits dropping values on different properties other than the parent of the dragged value. Closes Values are dropped when moved to a different Property #143
Removes AttributeError when undoing a change to property pseudo value. Closes Error on set Value Undo #138

Error occurred also when removing first of two multi-values or with completely empty values.

Also not on "<multi>" row.

When setting, also only one attribute is set at a time, otherwise resulting in AttributeError.

fschrader1992 · 2020-06-19T15:56:34Z

Checks for Code Quality:

Pylint
Rebase onto GNODE Master
Test with Python 3.8

mpsonntag

This is a very nice PR, thanks! 👍

fschrader1992 added 6 commits June 19, 2020 15:02

[tree_model] Add Reorder Function for Values

beddb12

Fix Reordering of Values

ebc64c6

[tree_model] Fix KeyError When Deleting One of Two Multi-Values

0aa124b

Error occurred also when removing first of two multi-values or with completely empty values.

[event] Make Reorder Specific to Values

1f87610

[targets] Allow Value Drop Only in Same Property

9d4c54e

Also not on "<multi>" row.

[commands] Allow Only One Attribute for Undo

0e80c11

When setting, also only one attribute is set at a time, otherwise resulting in AttributeError.

fschrader1992 force-pushed the values branch from 223315a to 0e80c11 Compare June 19, 2020 13:03

mpsonntag approved these changes Jun 22, 2020

View reviewed changes

mpsonntag merged commit fe352c2 into G-Node:master Jun 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Value Reordering #179

Value Reordering #179

fschrader1992 commented Jun 18, 2020 •

edited

Loading

fschrader1992 commented Jun 19, 2020

mpsonntag left a comment

Value Reordering #179

Value Reordering #179

Conversation

fschrader1992 commented Jun 18, 2020 • edited Loading

fschrader1992 commented Jun 19, 2020

mpsonntag left a comment

Choose a reason for hiding this comment

fschrader1992 commented Jun 18, 2020 •

edited

Loading