Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLReader potentially crashes on entity init #276

Closed
mpsonntag opened this issue Apr 5, 2018 · 0 comments · Fixed by #325
Closed

XMLReader potentially crashes on entity init #276

mpsonntag opened this issue Apr 5, 2018 · 0 comments · Fixed by #325
Assignees
@fschrader1992

Comments

@mpsonntag
Copy link
Contributor

If any of the init methods of Document, Section or Property lead to an uncaught Exception when the handling of an entity attribute fails; e.g. when a dtype of a Property does not match the provided value.

These exceptions should be caught and appropriately handled in case of ignore_errors=True to make the parser more robust for external usage e.g. in odml-ui.
@fschrader1992 fschrader1992 self-assigned this Aug 12, 2019
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Aug 20, 2019
@fschrader1992
[tools/xmlparser.py] Object Creation Errors to Warnings in Save Mode
5ffb743 
If ignore_errors is set, errors from object creation are converted
to warnings.

Related to issue G-Node#276.
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Aug 20, 2019
@fschrader1992
[text_parser_xml.py] Add Test for ignore_errors Mode
45ca2bc 
Including sample file.

Related to issue G-Node#276.
@fschrader1992 fschrader1992 mentioned this issue Aug 20, 2019
Merged
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Sep 25, 2019
@fschrader1992
[xmlparser.py] ignore_errors: Change Object Initialization
171a20f 
From Null to current type (Document, Section, Property).

Related to issue G-Node#276.
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Sep 25, 2019
@fschrader1992
[ignore_errors.xml] Add Further Test Cases
b209dc0 
Related to issue G-Node#276.
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Sep 25, 2019
@fschrader1992
[xmlparser.py] Catch ValueError at Object Creation
8f18f02 
Add more Specific Error Message.

Related to issue G-Node#276.
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Sep 25, 2019
@fschrader1992
[xmlparser.py] Remove Useless Import Statement
9beda58 
Related to issue G-Node#276.
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Sep 25, 2019
@fschrader1992
[text_parser_xml.py] Check Exceptions of ignore_error.xml File
9c32cfb 
Related to issue G-Node#276.
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Sep 26, 2019
@fschrader1992
[xmlparser.py] Revert Catch ValueError at Object Creation
420075f 
Catch all Exceptions.

Related to issue G-Node#276.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fschrader1992 fschrader1992

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RDF Converter, XML Reader Updates fschrader1992/python-odml
2 participants
@mpsonntag @fschrader1992