-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Value attribute differently named in odml and nixpy #308
Comments
I guess this should indeed be named in the same way. I am completely uncertain whether to favour |
I think |
I was about to suggest making it So I vote for To @jgrewe's point, we could also keep both. Is there a good reason for deprecating one in the long run? I guess it might lead to some confusion. Two properties where one is an alias for the other isn't common so some may take it as a signal that there's a difference (unless they read the documentation). That said, I wouldn't be against having both without deprecating (any time soon). |
I would vote for |
The
Property.value
accessor is differently named in odml (Property.value
) and nixpy (Property.values
).Should we unify this to either of the attribute names? This would be a breaking change.
The text was updated successfully, but these errors were encountered: