Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify deprecated 'Property.value' handling #360

Closed
3 tasks done
mpsonntag opened this issue Feb 24, 2020 · 0 comments · Fixed by #388
Closed
3 tasks done

Unify deprecated 'Property.value' handling #360

mpsonntag opened this issue Feb 24, 2020 · 0 comments · Fixed by #388
Assignees
@mpsonntag

Comments

@mpsonntag
Copy link
Contributor

mpsonntag commented Feb 24, 2020 •
edited
Loading

The Property.value attribute is deprecated!

  • the Property.value accessor methods currently use a print statement. Refactor to a proper deprecation warning using the warnings module.
  • in Property.__init__ the value can be keyword set, but does not elicit the deprecation warning.
  • in the Section.create_property() method value can be set as a keyword argument, but values can not. Refactor so that values can also be keyword set and that the usage of the value keyword elicits a deprecation warning.
@mpsonntag mpsonntag self-assigned this Apr 22, 2020
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Apr 22, 2020
@mpsonntag
[section] Add Property.value deprecation warning
a55c466 
Closes G-Node#360

Using the 'value' attribute with the create_property
method now elicits a 'warnings' module deprecation warning.
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Apr 27, 2020
@mpsonntag
[section] Add Property.value deprecation warning
46309de 
Closes G-Node#360

Using the 'value' attribute with the create_property
method now elicits a 'warnings' module deprecation warning.
@mpsonntag mpsonntag mentioned this issue Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpsonntag mpsonntag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor issue fixes and test reorganisation mpsonntag/python-odml
1 participant
@mpsonntag