Conversion encoding #297
Merged
Conversion encoding #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running parsers and converters with python2 it frequently happened to receive an encoding error while opening a file. Hopefully now encoding and usage of
unicodeis used everywhere where it is needed.This PR also adds a new private attribute
_origin_file_nameto thedocentity. When an odML document is loaded from file, this attribute is now set with the file name from whence the document was loaded. When writing an RDF file from an odML document that features an_origin_file_namethe value is exported asodml:hasFileName.The PR also makes
xmlthe defaultODMLWriterformat when writing a document to RDF since thexmlformat of RDF is still the format with the broadest acceptance.