Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional keywords in 'odml.save' #403

Merged
merged 5 commits into from
Oct 30, 2020

Conversation

mpsonntag
Copy link
Contributor

This PR adds the support for kwargs in via odml.save and odmlparser.ODMLWriter.

With this change both access points to writing odml files now also support specified save options:

  • saving XML documents with the localstyle option or a custom XSL string.
  • saving RDF documents with a different file format than the default XML format.

This PR closes issue #402.

To allow passing custom stylesheets for xml documents
also via the odml.save function, kwargs are now supported
in odml.save and the odmlparser has been adjusted accordingly.
Copy link
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 80.725% when pulling bf60ef7 on mpsonntag:kwargsSave into 24d7552 on G-Node:master.

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@achilleas-k achilleas-k linked an issue Oct 30, 2020 that may be closed by this pull request
@achilleas-k achilleas-k merged commit 4e23a93 into G-Node:master Oct 30, 2020
@mpsonntag mpsonntag deleted the kwargsSave branch November 2, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odml.save does not allow to include stylesheet
4 participants