feat: switch to using GitHub Security Advisory as IDs #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
use-github-advisory-ids
branch
from
2e55678
to
20eac43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the npm advisory database was merged into the GitHub advisory database, the IDs they provide in the audit output stopped being stable - this has gotten worse to the point of this: switching over to using the GitHub advisory ID when available.
I think this should be fine in all situations, though frankly I've been building a new tool (
osv-detector) that I'm hoping to replace this one, which is a lot better in a lot of ways including not interacting with package managers so a lot faster and more stable, so this is mainly a stopgap until that's fully formed.