fix: normalize names of python packages to favor false positives over false negatives #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments should say it all - ultimately I realised that
pip-compile
is probably why all therequirements.txt
I have locally are using lowercase package names, and that pip probably just accepts either or and normailizes names internally.Ultimately the OSV spec says that the name for packages in the PyPip ecosystem should be normalized, so let's normalize the names on both sides and call it a day for the time being.