Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize names of python packages to favor false positives over false negatives #56

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

G-Rath
Copy link
Owner

@G-Rath G-Rath commented Mar 11, 2022

The comments should say it all - ultimately I realised that pip-compile is probably why all the requirements.txt I have locally are using lowercase package names, and that pip probably just accepts either or and normailizes names internally.

Ultimately the OSV spec says that the name for packages in the PyPip ecosystem should be normalized, so let's normalize the names on both sides and call it a day for the time being.

@G-Rath G-Rath merged commit 4b2d304 into main Mar 11, 2022
@G-Rath G-Rath deleted the normalize-python-names branch March 11, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant