Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read DateTime values with Kind set based on isAdjustedToUtc #261

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Mar 14, 2022

Fixes #260

This changes behaviour and also breaks the ABI for LogicalRead so should be released with a major version bump.

@adamreeve adamreeve marked this pull request as ready for review March 21, 2022 20:26
@adamreeve adamreeve requested review from jgiannuzzi and removed request for jgiannuzzi March 21, 2022 20:26
@adamreeve adamreeve marked this pull request as draft March 22, 2022 20:14
@adamreeve adamreeve marked this pull request as ready for review March 23, 2022 22:45
Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Let's get 6.0.1 released before merging.

@jgiannuzzi jgiannuzzi merged commit 7cecf04 into G-Research:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParquetSharp should take into account "isAdjustedToUTC" for Timestamps
2 participants