Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up code and get NuGet package ready for the wild #10

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Tidy up code and get NuGet package ready for the wild #10

merged 3 commits into from
Jul 3, 2019

Conversation

gatesy
Copy link
Contributor

@gatesy gatesy commented Jul 3, 2019

  • Remove some dead code that wasn't referenced.
  • Remove dependencies that aren't needed.
  • Add in project properties for the NuGet package.

gatesy and others added 3 commits July 3, 2019 11:09
@gatesy
Added Ionide to gitignore
4e10d02
@gatesy
Tidy up and sort out NuGet package ready for the wild (#4)
786dd0e 
* Removed unreferenced files; made benchmarking not a test project

* Add back in the Appveyor logger

* Add properties for NuGet package
Change NuGet package name to PeregrineValueTypes
ef187cc
GR-GitHubRepo
GR-GitHubRepo approved these changes Jul 3, 2019
View reviewed changes
Copy link

@GR-GitHubRepo GR-GitHubRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GR-GitHubRepo GR-GitHubRepo merged commit 764c398 into G-Research:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GR-GitHubRepo GR-GitHubRepo GR-GitHubRepo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatesy @GR-GitHubRepo