Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix warnings & deprecation messages in the workflows #241

Conversation

ljubon
Copy link
Contributor

@ljubon ljubon commented May 14, 2024

What type of PR is this?

CI: Resolve deprecation & warning messages in workflows
Enable DependaBot for GitHub actions

What this PR does / why we need it:

Node16 has been out of support since September 2023. - more info in the post

Which issue(s) this PR fixes:

Resolves: https://github.com/G-Research/gr-oss/issues/640


Test results - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197206

It uses external actions dawidd6/action-download-artifact@246dbf436b23d7c49e21a7ab8204ca9ecd1fe615 which needs tobe

Testing results

🟢 Build JVM - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197205

🟠 Build Python - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197209
NOTE on upstream, this workflow is not run at all

🟢 Build Snapshot - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197204
NOTE on upstream, this workflow is not run at all

🟢 Check - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197212
NOTE this workflow is called from CI workflow, it can be verified it's green here

🟢 CI - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234

🟢 Test JVM - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234
NOTE this workflow is called from CI workflow, it can be verified it's green here

🟢 Test Python - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234
NOTE this workflow is called from CI workflow, it can be verified it's green here

🟢 Test results - https://github.com/gr-oss-devops/spark-extension/actions/runs/8878086091

Copy link

Test Results

   631 files  ±0     631 suites  ±0   1h 45m 4s ⏱️ + 1m 56s
   499 tests ±0     499 ✅ ±0   0 💤 ±0  0 ❌ ±0 
19 419 runs  ±0  19 355 ✅ ±0  64 💤 ±0  0 ❌ ±0 

Results for commit 6aeffe1. ± Comparison against base commit ce8737b.

Copy link
Contributor

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi added this pull request to the merge queue May 28, 2024
Merged via the queue into G-Research:master with commit cdcf650 May 28, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants