Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changeability #43

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Changeability #43

merged 5 commits into from
Jan 25, 2023

Conversation

- This commit is a _big_ overhaul, I address issues:
  - #32
  - #29
  - #13
- Many issues this is related to:
- #13
- #32 , partially, still testing.
- #29 & #17
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #43 (576c72f) into master (5c748f8) will decrease coverage by 0.16%.
The diff coverage is 74.50%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   75.30%   75.15%   -0.16%     
==========================================
  Files          33       31       -2     
  Lines        1968     1964       -4     
  Branches       78       80       +2     
==========================================
- Hits         1482     1476       -6     
- Misses        483      485       +2     
  Partials        3        3              
Impacted Files Coverage Δ
src/utils/init.ts 12.85% <12.50%> (+0.73%) ⬆️
src/services/user.service.ts 70.37% <72.16%> (+12.47%) ⬆️
src/utils/middleware.ts 77.20% <78.57%> (+6.21%) ⬆️
src/controllers/student.ts 89.69% <81.57%> (-1.67%) ⬇️
src/controllers/teacher.ts 90.29% <82.05%> (-1.67%) ⬇️
src/tests/helpers.ts 100.00% <100.00%> (ø)
src/utils/db.ts 68.13% <100.00%> (+0.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@G0maa G0maa merged commit 11390fa into master Jan 25, 2023
@G0maa G0maa deleted the changeability branch January 25, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant