Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update THANKS.txt #523

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Update THANKS.txt #523

merged 1 commit into from
Mar 20, 2023

Conversation

jltorrecilla
Copy link
Contributor

JL update and minor mistakes

JL update and minor mistakes
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ceb987) 85.63% compared to head (d5efb95) 85.63%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #523   +/-   ##
========================================
  Coverage    85.63%   85.63%           
========================================
  Files          143      143           
  Lines        11384    11384           
========================================
  Hits          9749     9749           
  Misses        1635     1635           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future we should probably look at alternatives for keeping the list of contributors up-to-date, such as https://allcontributors.org/.

@vnmabus vnmabus merged commit 26e4b85 into develop Mar 20, 2023
@vnmabus vnmabus deleted the jltorrecilla-patch-2 branch August 17, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants