Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Republish" feature to the data overlay #90

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Conversation

GBKS
Copy link
Owner

@GBKS GBKS commented Sep 20, 2024

The profile and follow list tabs in the data overlay now have subtle "Republish" text buttons (if you're logged in and the owner of that profile). Pressing will take that event and try to publish it to your relays.

With my own profile right now, publishing fails for most relays. Not cool. I need to check if those are dead by now, which seem to happen somewhat frequently. And there's an idea for another feature: helping users keep a clean relay list.

To keep users informed, I added a notification system. You'll get notifications slide in on the top right of the screen. They update as the publish status changes. They appear on success after 5s. Ones with errors stay around until you click them off.

So this is a helpful feature, but it's also a bit messy. Really needs more testing and polish.

Might also be helpful if the UI points out when there are multiple versions of events found, so users don't have to manually check. But that's probably best to add when the functionality is more stable.

Check the preview

Closes #84

The profile and follow list tabs in the data overlay now have subtle "Republish" text buttons (if you're logged in and the owner of that profile). Pressing will take that event and try to publish it to your relays.

With my own profile right now, publishing fails for most relays. Not cool. I need to check if those are dead by now, which seem to happen somewhat frequently. And there's an idea for another feature: helping users keep a clean relay list.

To keep users informed, I added a notification system. You'll get notifications slide in on the top right of the screen. They update as the publish status changes. They appear on success after 5s. Ones with errors stay around until you click them off.

So this is a helpful feature, but it's also a bit messy. Really needs more testing and polish.
@GBKS GBKS added the new feature New feature label Sep 20, 2024
@GBKS GBKS self-assigned this Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for regal-crostata-f23de2 ready!

Name Link
🔨 Latest commit b81fb7d
🔍 Latest deploy log https://app.netlify.com/sites/regal-crostata-f23de2/deploys/66fe60a409c7a2000802c04e
😎 Deploy Preview https://deploy-preview-90--regal-crostata-f23de2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Add editing of relays. The profile edit page now has a second tab for relays.

Just tested it and it works well. One problem I have is that the site gets its list of relays from Alby. But when post a new relay list event, Alby doesn't catch it right now. So the site still uses the old relay list. Not sure how to fix that yet.
@GBKS
Copy link
Owner Author

GBKS commented Oct 1, 2024

Also just pushed a new page for editing your own relays. Half of mine have died in the mean time.

So editing works, it's just that the site gets its list of clients from Alby, and Alby doesn't update that list right away when I publish a new event. So I refresh the page and still have my old list of relays. So basically I cannot relay on the extension data to be the latest, it should always be backed by loading from relays as well.

@GBKS
Copy link
Owner Author

GBKS commented Oct 3, 2024

Just did a bunch of testing. Still feels like some rough edges in a few places, but going to YOLO merge this and fix the rest little by little.

@GBKS GBKS merged commit c18ee29 into main Oct 3, 2024
4 checks passed
@GBKS GBKS deleted the feature/republish branch October 3, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to broadcast notes in data overlay
1 participant