Make centroid offset for low separations optional #9
Conversation
|
Centroid offset optional |
Creates balanced training set with 1comp, noise, and 2comp classes
If True, will output the central pixel spectrum and the 3x3 average spectrum as an H5 file. A second H5 file with the corresponding class labels is also created.
mcyc
dismissed
their stale review
I made a mistake of approving all 3 commits when I only intended to approve the first commit
|
Good to go? |
|
Functionally, I think so. Perhaps make outputting (2,2) lines optional? I have plans to modularize the code and enable multi-processing, as I did with my own version of the code, but that is not necessary for our test. |
|
Yes; I'm seeing that we're overloading this script with a lot of use cases, which are obviating the main purpose of providing a common set of tests. Factoring out the cube generation and having a set of routines that call pieces of this code seems like it would be preferred over putting everything in one script. |
|
Agreed, that's what I have in mind as well. |
|
Let's merge the pull request first. I can start modularizing the code following that. |
No description provided.