Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fragments read in the wrong order using Voiceover #4868

Closed
2 tasks
petertgiles opened this issue Nov 22, 2022 · 8 comments
Closed
2 tasks

Text fragments read in the wrong order using Voiceover #4868

petertgiles opened this issue Nov 22, 2022 · 8 comments
Assignees
Labels
accessibility Issues related to accessibility

Comments

@petertgiles
Copy link
Contributor

petertgiles commented Nov 22, 2022

(spun off from #4619)

❌ Current behaviour (issue)

When we use the hidden tag to hide part of the string for screen readers the text fragments are read out-of-order for MacOS voiceover. We're not sure if the issue affects other tools, too.

Screen Shot 2022-11-07 at 09 58 42

How to reproduce

  1. Environment - local, probably all
  2. Which browser and/or Assistive Technology? MacOS Voiceover, not sure about others
  3. Step-by-step instructions explaining how to reproduce the problem.
    1. Visit the homepage at https://uat-talentcloud.tbs-sct.gc.ca/en
    2. Find the "apply now" button in the "Browse Opportunities for the Indigenous community" section
    3. The read text will be "to the Indigenous Apprenticeship Program Apply now"

✔ Expected behaviour (fix)

The read text should be "Apply to the Indigenous Apprenticeship Program now"

Acceptance Criteria

A set of assumptions which, when tested, verify that the accessibility requirement was met.

  • Investigate an alternative strategy for specifying screen-reader-only text.
  • Text fragments for screen readers using the hidden tag a read out in the expected order using MacOS Voiceover
@petertgiles petertgiles added the accessibility Issues related to accessibility label Nov 22, 2022
@petertgiles petertgiles changed the title ⌨ Accessibility Issue Text fragments read in the wrong order using Voiceover Nov 22, 2022
@esizer
Copy link
Member

esizer commented Nov 22, 2022

So, this is likely a bug with data-h2-visibility="base(invisible)". We are using a common approach for this producing the fllowing css:

[data-h2] [data-h2-visibility*="base(invisible)"] {
    height: 1px;
    left: -100vw;
    overflow: hidden;
    position: absolute;
    top: 0;
    width: 1px;
 }

This is a bug with VoiceOver and absolutely positioned items or off screen elements (negative margin/location). Though, there does not seem to be a reliable fix as mentioned in #4586 (comment)

No one seems to know the fix 😢

@brindasasi
Copy link
Contributor

should we check in other screen reader tools may be ? ( other than voice over )

@esizer
Copy link
Member

esizer commented Mar 22, 2023

should we check in other screen reader tools may be ? ( other than voice over )

This is not an issue with NVDA or JAWS. Regardless, we should try to avoid hidden text if possible.

https://www.scottohara.me/blog/2023/03/21/visually-hidden-hack.html

@RM-1978
Copy link

RM-1978 commented Mar 22, 2023

Many apologies for the delay. I agree with Eric for multiple reasons including creating a consistent screen reading experience across users. I also feel that we should evaluate the text we are hiding to ensure that it is not integral to site operation for visual, non-verbal learners folks as well.

@esizer
Copy link
Member

esizer commented Mar 22, 2023

I also feel that we should evaluate the text we are hiding to ensure that it is not integral to site operation for visual, non-verbal learners folks as well.

Sadly, I think we have a lot of integral text hidden 😢 It would be great to have a content review to avoid this kind of thing and craft text that fits within the design constraints without needing to hide it from visual users as well.

@RM-1978
Copy link

RM-1978 commented Jul 19, 2023

Solution:
Remove hidden text and replace "Apply Now" button text with more descriptive text: " Apply IT Apprenticeship Program for Indigenous Peoples".

@esizer esizer removed the spike Learn more about something we can't estimate yet. label Jul 19, 2023
@RM-1978 RM-1978 removed the blocked: design Blocked by missing designs. label Jul 19, 2023
@mnigh
Copy link
Contributor

mnigh commented Jul 19, 2023

Solution: Remove hidden text and replace "Apply Now" button text with more descriptive text: " Apply IT Apprenticeship Program for Indigenous Peoples".

@RM-1978 was this a typo? should it not be the following: Apply to the IT Apprenticeship Program for Indigenous Peoples

@mnigh
Copy link
Contributor

mnigh commented Jul 20, 2023

Apply now text removed in #7223.

@mnigh mnigh closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility
Projects
Archived in project
Development

No branches or pull requests

8 participants