Exception handling and return values for put/remove #51

jannisveerkamp · 2015-10-15T08:29:01Z

@passsy

We should add more tests for failed put/remove actions. But I couldn't find a way to let them fail at all.

…ion was successful - added some exception handling within the constructor of a Preference

codecov-io · 2015-10-15T09:00:15Z

Current coverage is 100%

No coverage report found for develop at 0d912db.

Powered by Codecov. Last updated by 0d912db...f8313b6

- adjusted some tests - fixed persist missing return

passsy · 2015-10-15T12:54:30Z

in PreferenceStorage

setVersion() should return boolean
wipe() should return boolean
clear() should return boolean

In PreferenceAccessor

clear() should return boolean
wipe() should return boolean

passsy · 2015-10-15T15:23:15Z

library/src/androidTest/java/net/grandcentrix/tray/provider/TrayProviderHelperTest.java

+        assertFalse(providerHelper.persist(uri, STRING_A, null));
+        assertFalse(providerHelper.persist(MODULE_A, STRING_A, null));
+        assertFalse(providerHelper.persist(MODULE_A, STRING_A, null, null));
+    }


nice one! I struggled with this test

passsy · 2015-10-22T19:49:00Z

I thought about this and I'm not sure if this is the correct approach.

Tray is currently very heavy when it comes to performance.

A simple new MyTrayPreference(context) causes a ContentProvider request (~8ms) for the current version.
A pref.put("key", "value") costs ~12ms on a high end phone.

This performance problem should be addressed soon with a memory cache #22. The memory cache would make put and get methods which are void async. Additionally we have to add something like forcePut and forceGet to force a multiprocess sync to make the multiprocess functionality work as it does now. Those force methods return a boolean as proposed here.

Solving the version check in the constructor
We could build it similar to Androids SQLiteOpenHelper which opens the database after calling getWritableDatabase() (the version check happens there). This means new could is very cheap (maybe starting the async version check). The version needs to be checked before making a read/write request with the same error handling proposed here.

I don't want to merge it right now because of the API change which has to be reverted with the in-memory cache implementation.

passsy · 2015-11-05T14:39:48Z

@jannisveerkamp I'm now 100% sure the listener work (see #53), even in a multi process environment. I'm focusing now on a memory cache (#22)

release 1.0.0-rc3

The equality check before the deletion of migrated preferences only worked for strings as Tray stores everything as a string. The `toString()` ensures it works for boxed types as well.

This reverts commit 62817ca.

…g-prefs Fix deletion of non string migrated shared preferences.

passsy · 2016-07-04T09:52:02Z

I'm not worried about the API change anymore. SharedPreferences.Editor#commit() also returns a boolean. I'm looking forward to merge this.
//cc @jannisveerkamp @Mobbit

…improvements

…lean indicating success getVersion() throws TrayException when not successful simplifyed isVersionChangeChecked() moved all direct contentprovider access from ContentProviderStorage into TrayProviderHelper automatically catching all possible exceptions from the database

passsy · 2016-07-10T18:48:57Z

merged with #69

Jannis Veerkamp added 2 commits October 14, 2015 18:30

- added return values for put and remove which states whether the act…

b67fe46

…ion was successful - added some exception handling within the constructor of a Preference

refactoring

7ccca30

jannisveerkamp added the Ready for Review label Oct 15, 2015

passsy force-pushed the feature/exception_handling_and_put_remove_improvements branch from e495f49 to 7ccca30 Compare October 15, 2015 12:04

Jannis Veerkamp added 3 commits October 15, 2015 14:08

added tests for put/remove failure

eb419ec

added test for changeVersion retry policy

a394cb0

- added some tests

f9fc4f1

- adjusted some tests - fixed persist missing return

Jannis Veerkamp added 2 commits October 15, 2015 15:10

removed retry policy - always try one time

81de2fb

corrected test - 100% coverage again

778a7c5

passsy reviewed Oct 15, 2015
View reviewed changes

passsy and others added 10 commits November 5, 2015 18:09

Merge pull request #56 from grandcentrix/develop

ce18549

release 1.0.0-rc3

increased version to 1.0.0-rc3

806f53e

Fix deletion of non string migrated shared preferences.

5998d47

The equality check before the deletion of migrated preferences only worked for strings as Tray stores everything as a string. The `toString()` ensures it works for boxed types as well.

Don't abort because of lint errors in the sample project

2514d3f

Updated dependencies

62817ca

Increase APK install timeout on travis

1893e39

Revert "Updated dependencies"

16a0549

This reverts commit 62817ca.

Increase adb timeout drastically

6be0a8e

Merge pull request #65 from grandcentrix/bugfix/deletion-of-non-strin…

90cb301

…g-prefs Fix deletion of non string migrated shared preferences.

Prepare 0.10.0 release

bc3bf19

passsy mentioned this pull request Jul 4, 2016

return empty list when the cursor is null when doing query #68

Closed

passsy mentioned this pull request Jul 4, 2016

Feature/exception handling and put remove improvements #69

Merged

Pascal Welsch added 3 commits July 5, 2016 15:49

Merge branch 'master' into feature/exception_handling_and_put_remove_…

83750a8

…improvements

Format code and add missing javadoc

09bd455

Forward return values from ProviderHelper to Tray APIs

f8313b6

passsy closed this Jul 10, 2016

passsy deleted the feature/exception_handling_and_put_remove_improvements branch July 10, 2016 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exception handling and return values for put/remove #51

Exception handling and return values for put/remove #51

jannisveerkamp commented Oct 15, 2015

codecov-io commented Oct 15, 2015 •

edited

Loading

passsy commented Oct 15, 2015

passsy Oct 15, 2015

passsy commented Oct 22, 2015

passsy commented Nov 5, 2015

passsy commented Jul 4, 2016

passsy commented Jul 10, 2016

Exception handling and return values for put/remove #51

Exception handling and return values for put/remove #51

Conversation

jannisveerkamp commented Oct 15, 2015

codecov-io commented Oct 15, 2015 • edited Loading

Current coverage is 100%

passsy commented Oct 15, 2015

passsy Oct 15, 2015

Choose a reason for hiding this comment

passsy commented Oct 22, 2015

passsy commented Nov 5, 2015

passsy commented Jul 4, 2016

passsy commented Jul 10, 2016

codecov-io commented Oct 15, 2015 •

edited

Loading